Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43243

Deprecate unused code from javascript-static.js

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7
    • 2.7
    • JavaScript
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-43243-master
    • Hide
      • git grep for:
        • hide_item
        • getElementsByClassName
        • addonload
        • show_item
        • destroy_item

      Satisfy self that these are no longer used.
      Note, the getElementsByClassName function is defined in YUI, and jQuery too so you'll have to filter out the dross.

      • Add a new URL Resource
        • Confirm that the 'Choose a link...' button is visible with JS enabled
      • Click on the button
        • Confirm that the file picker appears
      • Disable JS
        • Confirm that the button disappears
      • Create a new Database activity
      • Add a new URL field
      • Add the default templates for the database
      • Add a new entry
        • Confirm that the 'Choose a link...' button is visible with JS enabled
      • Click on the button
        • Confirm that the file picker appears
      • Disable JS
        • Confirm that the button disappears
      Show
      git grep for: hide_item getElementsByClassName addonload show_item destroy_item Satisfy self that these are no longer used. Note, the getElementsByClassName function is defined in YUI, and jQuery too so you'll have to filter out the dross. Add a new URL Resource Confirm that the 'Choose a link...' button is visible with JS enabled Click on the button Confirm that the file picker appears Disable JS Confirm that the button disappears Create a new Database activity Add a new URL field Add the default templates for the database Add a new entry Confirm that the 'Choose a link...' button is visible with JS enabled Click on the button Confirm that the file picker appears Disable JS Confirm that the button disappears

      javascript-static.js needs to be deprecated in the longer term and replace by YUI modules.
      To start this process, I would like to start removing components of it which are no longer used.

      Keeping code around in case, one day, someone possibly, maybe, you know might want to use it is not a good enough reason IMO and since things of this nature are not used, they are not tested, and are potentially buggy.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Sam Hemelryk Sam Hemelryk
            Sam Hemelryk Sam Hemelryk
            Sam Hemelryk Sam Hemelryk
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.