Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43166

The CSS for left aligning text boxes for files, folders, ip addresses and urls is too specific.

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.6
    • Themes
    • None
    • MOODLE_26_STABLE

      This is caused by MDL-35275.

      Basically in that issue we added a bunch of very specific CSS targeting very specific fields. Ideally we should have an "ip address" form field which adds an "ipaddress" class to the text field, same for the other types, then the CSS could be reduced down to a handful of selectors (and it would be clear for developers in future that RTL should work like this).

      Example of bad CSS:

      .dir-rtl #adminsettings #id_s__pathtodu,                                                                                            
      .dir-rtl #adminsettings #id_s__aspellpath,                                                                                          
      .dir-rtl #adminsettings #id_s__pathtodot,                                                                                           
      .dir-rtl #adminsettings #id_s__supportemail,                                                                                        
      .dir-rtl #adminsettings #id_s__supportpage,                                                                                         
      .dir-rtl #adminsettings #id_s__sessioncookie,                                                                                       
      .dir-rtl #adminsettings #id_s__sessioncookiepath,                                                                                   
      .dir-rtl #adminsettings #id_s__sessioncookiedomain,                                                                                 
      .dir-rtl #adminsettings #id_s__proxyhost,                                                                                           
      .dir-rtl #adminsettings #id_s__proxyuser,                                                                                           
      .dir-rtl #adminsettings #id_s__proxypassword,                                                                                       
      .dir-rtl #adminsettings #id_s__proxybypass,                                                                                         
      .dir-rtl #adminsettings #id_s__jabberhost,                                                                                          
      .dir-rtl #adminsettings #id_s__jabberserver,                                                                                        
      .dir-rtl #adminsettings #id_s__jabberusername,        
      ...
      

            Unassigned Unassigned
            damyon Damyon Wiese
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.