Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43112

Change all "smallicon" and "iconsmall" classes to "icon-small"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Deferred
    • Icon: Minor Minor
    • None
    • 2.6
    • HTML and CSS, Themes
    • MOODLE_26_STABLE
    • wip-MDL-43112_master_4
    • Hide
      1. Perform a search of all of the code and confirm that there are no instances of 'smallicon' or 'iconsmall' bar in the Skype URL.
      2. Apply the patch.
      3. Ensure that the Skype logo still shows up on the profile page of a user with Skype details filled in.
      4. Login as an administrator. Go to "Site Administration" -> "Notifications" and confirm the block show / hide icons are the same size as previously.
      5. Create a course and turn editing on. Confirm that the course icons are the same size as previously.
        ....
      Show
      Perform a search of all of the code and confirm that there are no instances of 'smallicon' or 'iconsmall' bar in the Skype URL. Apply the patch. Ensure that the Skype logo still shows up on the profile page of a user with Skype details filled in. Login as an administrator. Go to "Site Administration" -> "Notifications" and confirm the block show / hide icons are the same size as previously. Create a course and turn editing on. Confirm that the course icons are the same size as previously. ....

      It seems that some people got mixed up and starting using "smallicon" instead of "iconsmall" for their icons.

      At some point later these two classnames started getting styled seperately.

      This has cause a few bugs where several icons in a line may have either class and look odd as a result. These bugs have generally been fixed by changing the class.

      The draft http://docs.moodle.org/dev/CSS_coding_style#Selectors states that selectors should have either a hyphen or an underscore as a separator between words. Therefore I propose that all "smallicon" and "iconsmall" classes be changed to "icon-small" in master only and '/theme/update.txt' be amended to inform contributed theme designers of the change.

        1. after.png
          34 kB
          Damyon Wiese
        2. before.png
          32 kB
          Damyon Wiese
        3. 2014-01-07 11_37_29-Course_ Topics_M26.png
          10 kB
          Gareth J Barnard
        4. 2014_02_05_12_50_54_Course_Topics.png
          3 kB
          Gareth J Barnard
        5. 2014_02_05_13_01_45_Course_Topics.png
          19 kB
          Gareth J Barnard
        6. 2014-02-05 23_36_14-Moodle GJB.png
          37 kB
          Gareth J Barnard
        7. 2014-02-05 23_39_49-Course_ Topics.png
          34 kB
          Gareth J Barnard
        8. afterburner_NEW.png
          11 kB
          Marina Glancy
        9. afterburner_OLD.png
          10 kB
          Marina Glancy
        10. blockmenu_NEW.png
          15 kB
          Marina Glancy
        11. blockmenu_OLD.png
          13 kB
          Marina Glancy
        12. context_NEW.png
          8 kB
          Marina Glancy
        13. context_OLD.png
          10 kB
          Marina Glancy
        14. courseman_NEW.png
          15 kB
          Marina Glancy
        15. courseman_OLD.png
          15 kB
          Marina Glancy
        16. coursesman_NEW.png
          53 kB
          Marina Glancy
        17. mainmenu_NEW.png
          9 kB
          Marina Glancy
        18. mainmenu_OLD.png
          8 kB
          Marina Glancy
        19. menu_NEW.png
          23 kB
          Marina Glancy
        20. menu_OLD.png
          23 kB
          Marina Glancy
        21. socialactivites_NEW.png
          14 kB
          Marina Glancy
        22. socialactivities_OLD.png
          13 kB
          Marina Glancy

            Unassigned Unassigned
            bawjaws David Scotson
            Mary Evans Mary Evans
            Marina Glancy Marina Glancy
            Votes:
            5 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.