Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-43018~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/f7434db...MDL-43018-master
Testing Instructions:
Hide

Open dev tools

Turn debug_developer off

Open any page in Moodle

Confirm that the first JS loaded is the rollup including:

moodlesimple; and;

mcore

Confirm that they both have -min.js in the filename

Confirm that the entire file content is minified

Turn the debug level up to debug_developer but leave yuicomboloading enabled

Refresh the page

Confirm that the moodlesimple filename is neither -min nor -debug (moodlesimple.js)

Confirm that the file content is not minified

Confirm the existence of Y.log in the content
Show
Open dev tools Turn debug_developer off Open any page in Moodle Confirm that the first JS loaded is the rollup including : moodlesimple; and; mcore Confirm that they both have -min.js in the filename Confirm that the entire file content is minified Turn the debug level up to debug_developer but leave yuicomboloading enabled Refresh the page Confirm that the moodlesimple filename is neither -min nor -debug (moodlesimple.js) Confirm that the file content is not minified Confirm the existence of Y.log in the content

if a javascript file ends with a semicolon, the semicolon is dropped at the end of a file. When combining some files, it breaks the code.

javascript file 1:
(function(foo){}(bar));

javascript file 2:
(function(bar){}(foo));

combined invalid javascipt:
(function(foo){}(bar))(function(bar){}(foo))

should be:
(function(foo){}(bar));(function(bar){}(foo));

lib/classes/minify.php line 87
$compressed[] = self::js($content);
to
$compressed[] = self::js($content) . ";";

blocks

MDL-43104 Combine simplemoodle + mcore

MDL-43105 Incorrect format used in rollups

Participants:: Andrew Lyons, Ankit Agarwal, Damyon Wiese, Dan Poltawski, Frédéric Massart, Matthew Davidson