Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Main Branch:
~~MDL-42951~~-master
Pull Main Diff URL:
https://github.com/FMCorz/moodle/compare/8d5a9d6...MDL-42951-master
Testing Instructions:
1. Make sure TEST_EXTERNAL_FILES_HTTP_URL is not set in your config.php, or is pointing to a local checkout of our repo moodle-exttests.
2. Run the unit tests in lib/tests/filelib_test.php.

https://github.com/moodle/moodle/blob/MOODLE_26_STABLE/lib/filelib.php#L3092-3099
libcurl sends "Expect: 100-continue" to web server, thus server responses something likes this:
HTTP/1.1 100 Continue
[blank line]
[full http response here]

Above code prevent formatHeader() format the real http response header, it causes curl->getResponse() returns empty array.

has been marked as being related by

MDL-43571 Incorrect view of PMs containing a plain text representing a curl CLI verbose output, including the HTML response

is a regression caused by

MDL-33955 Make download_file_content()/class curl to observe "moved" headers with open_basedir or safe_mode in effect

Participants:: Dan Poltawski, Dongsheng Cai, Eloy Lafuente (stronk7), Frédéric Massart, Michael de Raadt, Rossiani Wijaya, Sam Hemelryk