Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Main Branch:
~~MDL-42761~~-master
Pull Main Diff URL:
https://github.com/FMCorz/moodle/compare/0b10dfc...MDL-42761-master
Documentation link:
http://docs.moodle.org/dev/Help_strings#Help_string_formatting
Testing Instructions:
Hide

Open a course

Go to "Add a new badge" page

Click on the help popup (only seen if your instance is not accessible from the Internet)

Confirm that the content of the popup does not contain H2 headers, but you can still see some sort of heading.
Show
Open a course Go to "Add a new badge" page Click on the help popup (only seen if your instance is not accessible from the Internet) Confirm that the content of the popup does not contain H2 headers, but you can still see some sort of heading.

Open a course
Navigate to the "Add badges" page
Click on the help button next to the explanation of not being able to use badges properly because you're on a private machine

Expected

The headings in the help popup small, and less important from a DOM POV (not h2)

Actual

The headings are too big and H2s.

Testing discovered

MDL-42748 Help dialogue no longer handles long help texts

Participants:: CiBoT, Eloy Lafuente (stronk7), Frédéric Massart, Petr Skoda, Sam Hemelryk, Yuliya Bozhko