Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42414

One more time() random failure: test_increment_revision_number

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.6
    • 2.6
    • Unit tests
    • 2
    • BACKEND Sprint 6

      This is a follow-up of MDL-41935 that is already integrated and tested.

      A new random failure has been reported recently:

      core_datalib_testcase::test_increment_revision_number
      Failed asserting that '1381999791' is equal to 1381999792 or is greater than 1381999792.
       
      /var/lib/jenkins/git_repositories/master/lib/tests/datalib_test.php:335
      /var/lib/jenkins/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:80
      

      This is about to fix those assertions by using the new assertTimeCurrent() or, at least, move the time() calls to early in the test, so random second jumps don't happen in the middle.

            skodak Petr Skoda
            stronk7 Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Marina Glancy Marina Glancy
            Rossiani Wijaya Rossiani Wijaya
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.