Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42339

Remove double formatting set_title/set_heading over codebase

XMLWordPrintable

    • MOODLE_26_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Hide

      List of modules to test:

      1. chat
      2. choice
      3. data
      4. feedback
      5. forum
      6. glossary
      7. lesson
      8. lti
      9. page
      10. quiz
      11. survey
      12. wiki
      13. badges
      14. user/emailupdate.php

      Browse around the modules above and make sure there is no page title and header error displayed. Sample pages need to be looked at: view, edit, report, forum post, and other that specifically created for the module.

      Show
      List of modules to test: chat choice data feedback forum glossary lesson lti page quiz survey wiki badges user/emailupdate.php Browse around the modules above and make sure there is no page title and header error displayed. Sample pages need to be looked at: view, edit, report, forum post, and other that specifically created for the module.
    • 13
    • FRONTEND Sprint 9

      Both $PAGE->set_title() and $PAGE->set_heading() already process the contents passed with format_string(). So any call of this type:

      • $PAGE->set_title(format_string(… (there are 42 of this, at least)
      • $PAGE->set_heading(format_string(… (there are 25 of this, at least)

      Context in format_string() calls is only needed if it does not match current $PAGE->context OR if it has not been set. And any of these operations set it:

      • require_login() calls passing the 3rd, $cm parameter.
      • $PAGE->set_cm() calls.
      • $PAGE->set_context() explicit calls.

      This is about to search and destroy all those incorrect uses, looking to each carefully, ensuring that context is always set.

            rwijaya Rossiani Wijaya
            rwijaya Rossiani Wijaya
            Jérôme Mouneyrac Jérôme Mouneyrac
            Marina Glancy Marina Glancy
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.