Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Epic Link:
Clean as default
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Main Branch:
~~MDL-42195~~-master
Pull Main Diff URL:
https://github.com/damyon/moodle/compare/fc7557677de76602640b4478f91c641944c6c342...MDL-42195-master
Testing Instructions:
Hide

Test using Clean

Create an image in tinymce and set the width and height to non-default values (make it an obviously different ratio)

Verify the image shows in the editor with the new size

Save the content and verify the saved content is displayed at the new size.

Repeat test with Atto

Look at the Scorm objectives report

Make your browser about 800px wide and verify the user picture column is not squashed into the next one.

Go to any page using a flexible table and hide a column. Verify the show image is bigger than 1x1 pixels.
Show
Test using Clean Create an image in tinymce and set the width and height to non-default values (make it an obviously different ratio) Verify the image shows in the editor with the new size Save the content and verify the saved content is displayed at the new size. Repeat test with Atto Look at the Scorm objectives report Make your browser about 800px wide and verify the user picture column is not squashed into the next one. Go to any page using a flexible table and hide a column. Verify the show image is bigger than 1x1 pixels.

After changing the dimensions of the image the image is still display with its original dimension.

This prevents setting a width/height on images in Atto and TinyMCE, and has broken all sorts of images all over Moodle.

Bootstrap 3 reverted this behaviour to make it opt-in - but we are stuck with Bootstrap 2.

has a non-specific relationship to

MDL-45034 Image sizing options dialog is less clear than it could be

MDL-45017 Allow responsive images in user generated content

Testing discovered

MDL-45014 Wrong image type selected appears underneath filepicker

MDL-45016 Breadcrump does not appear nicely in IE8 using Clean

Participants:: Andrew Lyons, CiBoT, Damyon Wiese, Dan Poltawski, David Scotson, Frédéric Massart, Gareth J Barnard, Jetha Chan, Marina Glancy, Martin Dougiamas, Mary Evans, Michael de Raadt, Moodle HQ, Raphael, Rebecca Trynes, Stuart Lamour