Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41650

Tags use unsemantic .red and .green classes for notification rather than .notifysuccess and .notifyproblem

XMLWordPrintable

    • MOODLE_25_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • wip-MDL-41650-master
    • Hide

      Go to Settings > Site administration > Appearance > Manage tags
      Here try to create a new tag with name that already exists.
      This provide an error. Check it has red background.
      Create a valid tag again.
      This provides success notification. Check it has green background.

      Show
      Go to Settings > Site administration > Appearance > Manage tags Here try to create a new tag with name that already exists. This provide an error. Check it has red background. Create a valid tag again. This provides success notification. Check it has green background.

      tag/manage.php
      163: echo $OUTPUT->notification($err_notice, 'red');
      166: echo $OUTPUT->notification($notice, 'green');

      These lines should use 'notifyproblem' in place of 'red' and 'notifysuccess' in place of 'green'.

      It's possible this is the one and only use of the classes red and green in core Moodle, so perhaps they should simply be removed from the CSS at the same time?

            apsdehal Amanpreet Singh
            bawjaws David Scotson
            Frédéric Massart Frédéric Massart
            Andrew Lyons Andrew Lyons
            Jun Pataleta Jun Pataleta
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.