-
Bug
-
Resolution: Fixed
-
Minor
-
2.6
-
MOODLE_26_STABLE
-
MOODLE_26_STABLE
-
wip-
MDL-41419-master -
-
2
-
BACKEND Sprint 4
This test keeps failing on the integration server because of minor time differences.
- Ideally you would change the test so it doesn't depend on us having the two evaluations happen within 1 second of each other because that often leads to failures.
- But also, your test data is wrong, its passing because php sucks, but as this diff below shows:
- 'itemid' => 1 should be 'itemid' => '1'
- 'isdir' => null should be 'isdir' => false
Output:
core_files_externallib_testcase::test_get_files
|
Failed asserting that two arrays are equal.
|
--- Expected
|
+++ Actual
|
@@ @@
|
'filearea' => 'content'
|
- 'itemid' => '1'
|
+ 'itemid' => 1
|
'filepath' => '/'
|
'filename' => 'Simple4.txt'
|
'url' => 'http://www.example.com/moodle...e4.txt'
|
- 'isdir' => false
|
- 'timemodified' => '1377497719'
|
+ 'isdir' => null
|
+ 'timemodified' => '1377497718'
|
)
|
)
|
)
|
|
|
/var/lib/jenkins/git_repositories/master/files/tests/externallib_test.php:285
|
/var/lib/jenkins/git_repositories/master/lib/phpunit/classes/advanced_testcase.php:76
|
- is a regression caused by
-
MDL-40038 Remove contextid from core_files_external::get_files
-
- Closed
-