Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41343

Create update_course_record

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.6
    • Libraries
    • MOODLE_26_STABLE

      This is a follow on issue from MDL-39876.

      Sam M created a patch that introduced a new method update_course_record that both updated the database and updated $SITE and $COURSE if required.
      At the time it was reverted because it caused issues initialising phpunit, installing via CLI, and when editing front page settings.
      I think the change still has merits however there are still issues to address.

      To change:

      • The CLI installation and front page bugs appear to come from trying to update $SITE, they will need to be addressed (3x in lib/adminlib.php)
      • The if...elseif in the function should be two ifs (incase $COURSE==$SITE)
      • The function should only interact with DB columns (because some idiot developers like to add/remove from records)
      • The datatypes in the functions should be thought about, do we need to convert before setting to the globals, mimicking a fetch?

            quen Sam Marshall
            samhemelryk Sam Hemelryk
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.