Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40621

TinyMCE plugins api little fix

XMLWordPrintable

    • MOODLE_25_STABLE
    • MOODLE_24_STABLE, MOODLE_25_STABLE
    • wip-MDL-40621-master
    • Hide

      This function is not really often used so the test is quite made up:

      1. Disable setting requiretex (or enable Tex filter)
      2. Open any page with html editor and make sure the button "Insert equation" appears in the 3rd row before the nonbreaking button.
      3. Modify TinyMCE settings and merge together 2nd and 3rd row of buttons
      4. Open any page with html editor and make sure the button "Insert equation" appears in the 2rd row before the nonbreaking button.
      Show
      This function is not really often used so the test is quite made up: Disable setting requiretex (or enable Tex filter) Open any page with html editor and make sure the button "Insert equation" appears in the 3rd row before the nonbreaking button. Modify TinyMCE settings and merge together 2nd and 3rd row of buttons Open any page with html editor and make sure the button "Insert equation" appears in the 2rd row before the nonbreaking button.

      While testing/debugging MDL-37565 I found a small bug in class editor_tinymce_plugin and couple of copy-pasted comments. Now when we develop more and more TinyMCE plugins this may appear more often.

      Problem: editor_tinymce_plugin::fix_row() always return 1 when specified row is not found. Presumably it was supposed to return the maximum available row number if specified row was too big.

        1. master_2rows.png
          master_2rows.png
          22 kB
        2. master_3rows.png
          master_3rows.png
          24 kB

            marina Marina Glancy
            marina Marina Glancy
            Petr Skoda Petr Skoda
            Damyon Wiese Damyon Wiese
            Rossiani Wijaya Rossiani Wijaya
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.