Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
git://github.com/tlock/moodle.git
Pull Main Branch:
mdl40346-master
Pull Main Diff URL:
https://github.com/tlock/moodle/commit/2abbe7fcd199f879dcf1811d674a3b427b30827a
Testing Instructions:

Hide

1/ configure external openldap test server (see http://docs.moodle.org/dev/PHPUnit_installation_in_OS_X#Install_and_configure_OpenLDAP)
2/ run unit tests

Show
1/ configure external openldap test server (see http://docs.moodle.org/dev/PHPUnit_installation_in_OS_X#Install_and_configure_OpenLDAP ) 2/ run unit tests

Ran ldap sync and got this error:

	Inserted user xxxxxxxx id xxxxx

PHP Notice:  Undefined property: stdClass::$id in /var/www/moodle/auth/ldap/auth.php on line 1042

PHP Stack trace:

PHP   1. {main}() /var/www/moodle/auth/ldap/cli/sync_users.php:0

PHP   2. auth_plugin_ldap->sync_users() /var/www/moodle/auth/ldap/cli/sync_users.php:67

Introduced by ~~MDL-39166~~.

blocks

MDL-40243 LDAP cron synchronization script not suspending user

is a regression caused by

MDL-39166 LDAP auth plugin doesn't call events_trigger() when user record updated

Participants:: Damyon Wiese, Justin Filip, Michael de Raadt, Petr Skoda, Rajesh Taneja, Tim Lock