Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39458

get_max_upload_sizes requires a DB query

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.5
    • Administration
    • MOODLE_25_STABLE

      When setting up the admin tree, there are a few settings that call get_max_upload_sizes to build a select list for setting the max file size for an area. If the current value is not in CFG - an extra DB call is required (or cache hit).

      This is just to catch the edge case when php.ini defined some non-standard value as the server limit, the activity was set to exactly that limit and then the limit changed. In order to always have the current value in the list we need to retrieve it from the DB/cache when building the list of options.

      Alternative suggestions welcome for how this should behave (One suggestion might be a custom adminsetting for this type of field that does the right thing when the current value is not in the list - either adds it or selects the next lowest/highest).

      We have gone with the perf hit for 2.5 but want to keep improving this issue.

            moodle.com Moodle HQ
            damyon Damyon Wiese
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.