Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
git://github.com/sammarshallou/moodle.git
Pull Main Branch:
~~MDL-39454~~-master
Pull Main Diff URL:
https://github.com/sammarshallou/moodle/compare/master...MDL-39454-master
Testing Instructions:

Hide

1. View a course page when logged in as admin. Verify that there are no errors and that you have full access to course options e.g. the 'turn editing on' button.

2. Log in as a student and view the same page. Verify that there are no errors and that you do not have the 'turn editing on' button/option.

Show
1. View a course page when logged in as admin. Verify that there are no errors and that you have full access to course options e.g. the 'turn editing on' button. 2. Log in as a student and view the same page. Verify that there are no errors and that you do not have the 'turn editing on' button/option.

In a typical page request, is_siteadmin gets called more than 200 times. In my profiling this takes about 5ms.

The function is not very efficient. I am investigating two approaches to improve performance with the aim of saving a couple of milliseconds.

Participants:: Andrew Lyons, Dan Poltawski, Jason Fowler, Marina Glancy, Petr Skoda, Sam Hemelryk, Sam Marshall