Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE, MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
https://github.com/kiratskitizing/moodle
Pull Main Branch:
~~MDL-39324~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...kiratskitizing:MDL-39324-master
Testing Instructions:
Hide

Create a course.

Turn editing on.

Add a URL resource.

Name: ~~MDL-39324~~ URL

External URL: http://techslides.com/demos/sample-videos/small.flv

Click "Save and return to course".

Notice that the icon of the URL resource is correct. It is using the Fl icon.

Edit the URL resource.

Set the External URL to:
http://techslides.com/demos/sample-videos/small.flv?d=50x75

Click "Save and return to course".

RESULT:
The icon for the URL resource should still use the Fl icon and not the "default icon".
Show
Create a course. Turn editing on. Add a URL resource. Name: MDL-39324 URL External URL: http://techslides.com/demos/sample-videos/small.flv Click "Save and return to course". Notice that the icon of the URL resource is correct. It is using the Fl icon. Edit the URL resource. Set the External URL to: http://techslides.com/demos/sample-videos/small.flv?d=50x75 Click "Save and return to course". RESULT: The icon for the URL resource should still use the Fl icon and not the "default icon".

After adding custom video dimensions (?d="width"x"height") the media icon gets replaced with the default one .

IMHO the addition of URL parameters shouldn't have an influence on the icon.

caused a regression

MDL-73195 mod_url: Error makes course/view.php unreachable if an invalid URL is saved

Participants:: CiBoT, Gladys Basiana, Joshua Ebarvia, Jun Pataleta, Mihail Geshoski, Paola Maneggia, Philipp Pavelka, Simey Lameze

Estimated:

Not Specified

Remaining:

Logged:

3h 3m