Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Main Branch:
~~MDL-38934~~-master
Pull Main Diff URL:
https://github.com/danpoltawski/moodle/compare/422f68fb869465fa162a282c27a02b4aaecd3ea6...MDL-38934-master
Testing Instructions:
Hide

Note: ignore mod_assign form errors

Add a new mod_assign instances with the grading method set to advanced grading.

Add another mod_assign instance and set the grading method to rubric.

Visit the grading pages for these assignments.

Verify that there are no setType errors on the grading screens.
Show
Note: ignore mod_assign form errors Add a new mod_assign instances with the grading method set to advanced grading. Add another mod_assign instance and set the grading method to rubric. Visit the grading pages for these assignments. Verify that there are no setType errors on the grading screens.

I've seen a missing call in both rubrics and marking guide:

Did you remember to call setType() for 'returnurl'? Defaulting to PARAM_RAW cleaning.

line 1291 of /lib/formslib.php: call to debugging()

line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

line 202 of /lib/formslib.php: call to moodleform->_process_submission()

line 46 of /grade/grading/form/guide/edit.php: call to moodleform->moodleform()

Did you remember to call setType() for 'returnurl'? Defaulting to PARAM_RAW cleaning.

line 1291 of /lib/formslib.php: call to debugging()

line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

line 202 of /lib/formslib.php: call to moodleform->_process_submission()

line 45 of /grade/grading/form/rubric/edit.php: call to moodleform->moodleform()

Participants:: Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Mark Nelson