Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38865

Activity completion report uses an unnecessarily broad CSS selector

XMLWordPrintable

    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • MDL-38865-master
    • Hide

      To test this patch, you'll need some arbitrary tabular content. I added the following via Appearance > Additional HTML > When BODY is opened: <table><tr><th><em>Doom at 11.</em></th></tr></table>. To see the issue properly you'll also need a body background-color that isn't the usual flat grey since the table border blends right in. I went with a garish body { background-color: red} in my Custom CSS.

      1. Activate completion tracking in Advanced Features.
      2. Enable completion tracking in a test course.
      3. Enable completion tracking in an activity in that course.
      4. Enroll at least one student in the course.
      5. Access the Activity Completion report.
      6. Verify that your arbitrary tabular content doesn't have a border.
      Show
      To test this patch, you'll need some arbitrary tabular content. I added the following via Appearance > Additional HTML > When BODY is opened: <table><tr><th><em>Doom at 11.</em></th></tr></table> . To see the issue properly you'll also need a body background-color that isn't the usual flat grey since the table border blends right in. I went with a garish body { background-color: red } in my Custom CSS. Activate completion tracking in Advanced Features. Enable completion tracking in a test course. Enable completion tracking in an activity in that course. Enroll at least one student in the course. Access the Activity Completion report. Verify that your arbitrary tabular content doesn't have a border.

      The activity completion report (report/progress) applies styles to all tables on the page. This isn't necessary since it only generates one table and that table always has the id completion-progress. If you have any other tables on that page (from a custom theme perhaps) they'll get that style applied too.

            cfulton Charles Fulton
            cfulton Charles Fulton
            Dan Poltawski Dan Poltawski
            Damyon Wiese Damyon Wiese
            Rajesh Taneja Rajesh Taneja
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.