Loading...

XML

Word

Printable

Type: Sub-task
Resolution: Fixed
Priority: Major
Fix Version/s: 2.5
Affects Version/s: 2.5
Component/s: Forms Library, Gradebook
Labels:
- triaged

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/andyjdavis/moodle.git
Pull Main Branch:
~~MDL-38833~~_settype
Pull Main Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-38833_settype
Testing Instructions:

Hide

You'll need two gradeable activities. One using a numeric grade. The other using a custom scale.

As a teacher or admin go to the grader report and turn editing on. Click the edit/cog icon next to an individual student grade. Tick 'overridden' if it isnt ticked already. Edit the student's grade and click update.

Repeat this for both activities. Make sure you don't see the warning in this MDL's description and that the grade changes are saved correctly.

Show
You'll need two gradeable activities. One using a numeric grade. The other using a custom scale. As a teacher or admin go to the grader report and turn editing on. Click the edit/cog icon next to an individual student grade. Tick 'overridden' if it isnt ticked already. Edit the student's grade and click update. Repeat this for both activities. Make sure you don't see the warning in this MDL's description and that the grade changes are saved correctly.

If I go to the grader report, turn editing on, click the edit icon for an individual student grade then save the resulting form the following is displayed.

Did you remember to call setType() for 'finalgrade'? Defaulting to PARAM_RAW cleaning.

    line 1275 of /lib/formslib.php: call to debugging()

    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

    line 202 of /lib/formslib.php: call to moodleform->_process_submission()

    line 105 of /grade/edit/tree/grade.php: call to moodleform->moodleform()

Discovered while testing

MDL-39360 Should we be using PARAM_RAW or PARAM_FLOAT for grades

Closed

Testing discovered

MDL-38445 In Grades, a hidden test may reappear after an attempt by a student

Closed

Assignee:: Andrew Davis

Reporter:: Andrew Davis

Peer reviewer:: Ankit Agarwal

Integrator:: Damyon Wiese

Tester:: Damyon Wiese

Participants:: Andrew Davis, Ankit Agarwal, Damyon Wiese, Dan Poltawski

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 02/Apr/13 10:34 AM

Updated:: 08/May/13 7:11 AM

Resolved:: 02/May/13 10:28 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify