Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-38756~~-m
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/commit/MDL-38756-m
Testing Instructions:
Hide

Testing difficulty: medium (requires 2.5dev installation)

Install a fresh new site using the installation method of existing config.php + no DB + no moodledata:

Ensure that jsrev is not set in your config.php, and that:

$CFG->debug = (E_ALL | E_STRICT);

$CFG->debugdisplay = true;

dump your database and moodledata

reinstall

On the first page of the installation:

Confirm that no errors were shown about missing vars

(you may want to confirm that you do get them without the patch too)
Show
Testing difficulty: medium (requires 2.5dev installation) Install a fresh new site using the installation method of existing config.php + no DB + no moodledata: Ensure that jsrev is not set in your config.php, and that: $CFG->debug = (E_ALL | E_STRICT); $CFG->debugdisplay = true; dump your database and moodledata reinstall On the first page of the installation: Confirm that no errors were shown about missing vars (you may want to confirm that you do get them without the patch too)

As reported by David Mudrak:

During install, jsrev is not yet set, and should really not attempt to use the cached copy of the metadata.

As part of the installation, jsrev is then set to the current timestamp.

We should therefore check whether jsrev is -1, OR is not set at all.

Participants:: Andrew Lyons, Ankit Agarwal, Damyon Wiese, Dan Poltawski, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7)