Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Main Branch:
~~MDL-38744~~-master
Pull Main Diff URL:
https://github.com/danpoltawski/moodle/compare/d8201d49d8e0f18c3c836d9d4813edf2fb8728ee...MDL-38744-master
Testing Instructions:
Hide

Edit course settings

In course settings > completion progress > set completion progress to enabled

Go to course settings > completion tracking

VERIFY: no debugging message is displayed

In the Course grade section, set to enabled and add a float value in the grade section

Save the settings

VERIFY: the grade is saved by browsing back to the form

Change your language to french

Add a decimal value using a ','

VERIFY the value is saved
Show
Edit course settings In course settings > completion progress > set completion progress to enabled Go to course settings > completion tracking VERIFY: no debugging message is displayed In the Course grade section, set to enabled and add a float value in the grade section Save the settings VERIFY: the grade is saved by browsing back to the form Change your language to french Add a decimal value using a ',' VERIFY the value is saved

This now triggers debugging messages since ~~MDL-34311~~.

Did you remember to call setType() for 'criteria_grade_value'? Defaulting to PARAM_RAW cleaning.

* line 1275 of /lib/formslib.php: call to debugging()

* line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

* line 202 of /lib/formslib.php: call to moodleform->_process_submission()

* line 73 of /course/completion.php: call to moodleform->moodleform()

is duplicated by

MDL-38930 Completion settings page shows setType() warnings

Participants:: Adrian Greeve, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7)