-
Bug
-
Resolution: Fixed
-
Minor
-
2.5
-
MOODLE_25_STABLE
-
MOODLE_25_STABLE
-
MDL-38733-workshop-rubric-css -
In Moodle 2.5, Moodle form section headers have apparently changed their HTML attribute "id" and it now uses the id_ prefix. I'm not sure but this part of the d23edcf1517dc2c54199287ad3f9f7ecb420f943 commit may be causing it.
@@ -2555,10 +2569,10 @@ class MoodleQuickForm_Renderer extends HTML_QuickForm_Renderer_Tableless{
|
function renderHeader(&$header) {
|
global $PAGE;
|
|
+ $header->_generateId();
|
$name = $header->getName();
|
|
- $id = empty($name) ? '' : ' id="' . $name . '"';
|
- $id = preg_replace(array('/\]/', '/\[/'), array('', '_'), $id);
|
+ $id = empty($name) ? '' : ' id="' . $header->getAttribute('id') . '"';
|
if (is_null($header->_text)) {
|
$header_html = '';
|
} elseif (!empty($name) && isset($this->_templates[$name])) {
|
}
|
This caused a regression in Workshop rubrics. They are implemented in a pretty hacky way and their CSS relies on the header ID attribute.
- is a regression caused by
-
MDL-37932 Add advanced option to repeat_elements
-
- Closed
-