Loading...

XML

Word

Printable

Type: Sub-task
Resolution: Fixed
Priority: Critical
Fix Version/s: 2.3.7, 2.4.4
Affects Version/s: 2.3.6, 2.4.3, 2.5
Component/s: JavaScript
Labels:

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-38658~~-m
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/commit/MDL-38658-m
Difficulty:
Easy
Testing Instructions:
Hide

Ensure that you have cachejs enabled, and jsrev not set

Open dev tools to the 'Network' tab

Open course page and turn editing on

Check that the course/dndupload.js was loaded through lib/javascript.php

Check that dndupload works
Show
Ensure that you have cachejs enabled, and jsrev not set Open dev tools to the 'Network' tab Open course page and turn editing on Check that the course/dndupload.js was loaded through lib/javascript.php Check that dndupload works

I just discovered that the defintion in course/dnduploadlib.php for inclusion of the JS code (course/dndupload.js) uses a moodle_url, so is not using lib/javascript.php and is not being sent with caching headers.

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Petr Skoda

Integrator:: Eloy Lafuente (stronk7)

Tester:: Jason Fowler

Participants:: Andrew Lyons, Damyon Wiese, Eloy Lafuente (stronk7), Jason Fowler, Petr Skoda

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 23/Mar/13 1:23 AM

Updated:: 28/Mar/13 4:40 PM

Resolved:: 28/Mar/13 4:40 PM

Details

Description

Attachments

Activity

People

Dates

Clockify