Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37779 unit test fixing META
  3. MDL-38524

hardcoded behat version in composer blocks phpunit upgrades

XMLWordPrintable

    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • MDL-38524_master
    • Hide
      1. Delete composer.lock and vendor/ from $CFG->dirroot if they exist
      2. Run the composer installer (http://docs.moodle.org/dev/Acceptance_testing#Installation)
      3. You SHOULD NOT receive any dependecies conflict error
      4. Open composer.lock and check the installed versions, the "version" attribute is below the "name" attribute we are looking for:
        • Search "name": "phpunit/phpunit", it SHOULD match 3.7.18
        • Search "name": "behat/behat", it SHOULD match 2.4.5
        • Search "name": "symfony/yaml", is SHOULD match 2.2.0
      5. Run the behat test suit (http://docs.moodle.org/dev/Acceptance_testing#Running_tests)
      6. They SHOULD all pass
      7. Run the phpunit suit with vendor/bin/phpunit (http://docs.moodle.org/dev/PHPUnit#Test_execution_via_Composer)
      8. They SHOULD all pass
      Show
      Delete composer.lock and vendor/ from $CFG->dirroot if they exist Run the composer installer ( http://docs.moodle.org/dev/Acceptance_testing#Installation ) You SHOULD NOT receive any dependecies conflict error Open composer.lock and check the installed versions, the "version" attribute is below the "name" attribute we are looking for: Search "name": "phpunit/phpunit" , it SHOULD match 3.7.18 Search "name": "behat/behat" , it SHOULD match 2.4.5 Search "name": "symfony/yaml" , is SHOULD match 2.2.0 Run the behat test suit ( http://docs.moodle.org/dev/Acceptance_testing#Running_tests ) They SHOULD all pass Run the phpunit suit with vendor/bin/phpunit ( http://docs.moodle.org/dev/PHPUnit#Test_execution_via_Composer ) They SHOULD all pass

      Do not hardcode any minor versions in composer file in dev versions:

      "moodlehq/behat-extension": "1.0.3"

      if there are problems with minor versions we need to resolve them, hardcoding is possible only in stable branches...

            dmonllao David Monllaó
            skodak Petr Skoda
            Petr Skoda Petr Skoda
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Ankit Agarwal Ankit Agarwal
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.