Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38285 Migrate moodle- YUI modules to use shifter
  3. MDL-38520

Migrate moodle-core-formchangechecker to use Shifter

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.5
    • 2.5
    • JavaScript
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • Hide

      Generic Notes

      These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = 0;
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      • Open a moodle form - perhaps the profile editing form to spice things up after all of those course tests you've been doing*
      • Refresh the page without changes
        • Confirm no warning
      • Make a change to a textbox and refresh
        • Confirm a warning was shown (don't reload)
        • Confirm the page does not reload
      • Try to navigate away
        • Confirm a warning was shown (don't reload)
        • Confirm the page does not change
      • Try to close the browser tab
        • Confirm a warning was shown (don't reload)
        • Confirm the page does not close
      • Reload the page and accept the warning
      • Repeat with a dropdown
      • Repeat with an HTML editor
      Show
      Generic Notes These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = 0; Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions Open a moodle form - perhaps the profile editing form to spice things up after all of those course tests you've been doing* Refresh the page without changes Confirm no warning Make a change to a textbox and refresh Confirm a warning was shown (don't reload) Confirm the page does not reload Try to navigate away Confirm a warning was shown (don't reload) Confirm the page does not change Try to close the browser tab Confirm a warning was shown (don't reload) Confirm the page does not close Reload the page and accept the warning Repeat with a dropdown Repeat with an HTML editor

      Migrate moodle-core-formchangechecker to use Shifter

      Also needs to be renamed to moodle-form-changechecker but best done as a separate task to make it easier to test.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.