Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38285 Migrate moodle- YUI modules to use shifter
  3. MDL-38516

Migrate moodle-block_navigation-navigation to use Shifter

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.5
    • 2.5
    • JavaScript
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • Hide

      Generic Notes

      These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      // Ensure you aren't overriding $CFG->jsrev
      $CFG->debug = 0;
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      • Open any page in Moodle which uses the navigation block
        • Confirm that you can still expand/collapse nodes
        • Confirm that when you expand a Course node, there is a call to /lib/ajax/getnavbranch.php and the branch loads any relevant content

      Testing keyboard use

      • Use the tab key to get to the navigation
        • Confirm that left/right open and close branches
        • Confirm that enter/space toggle opening/closing of branches
      • Open down to a course and tab to the Participants list
        • Confirm that space always toggles a node
        • Confirm that the 'enter' key toggles the 'Current course' node
        • Confirm that the 'enter' key selects the 'Participants' node
      Show
      Generic Notes These testing instructions should be carried out twice (once with jsrev = -1, once without) to confirm that the correct versions of JS are used and work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: // Ensure you aren't overriding $CFG->jsrev $CFG->debug = 0; Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions Open any page in Moodle which uses the navigation block Confirm that you can still expand/collapse nodes Confirm that when you expand a Course node, there is a call to /lib/ajax/getnavbranch.php and the branch loads any relevant content Testing keyboard use Use the tab key to get to the navigation Confirm that left/right open and close branches Confirm that enter/space toggle opening/closing of branches Open down to a course and tab to the Participants list Confirm that space always toggles a node Confirm that the 'enter' key toggles the 'Current course' node Confirm that the 'enter' key selects the 'Participants' node

      Migrate moodle-block_navigation-navigation to use Shifter

      This is one of the larger modules that we have and it's loaded on most pages in Moodle.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.