Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38285 Migrate moodle- YUI modules to use shifter
  3. MDL-38470

Rebuild moodle-core-tooltip

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.5
    • 2.5
    • JavaScript
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • Hide

      Note: As always, recommend having the developer toolset open

      With developer mode disabled and enabled:

        • Confirm that the URL for all moodle JS loaded through yui_combo.php have -min.js on the end of the filename
      • Restrict the Network tab to JavaScript
      • Log out and navigate to the Login page
        • Confirm that moodle-core-tooltip loaded successfully in your browser
        • Confirm that a minified version was loaded if debugging was not enabled
        • Confirm that a non-minified version was loaded if debugging was enabled
        • Confirm that clicking on the [?] icon brings up the help popup correctly
      Show
      Note: As always, recommend having the developer toolset open With developer mode disabled and enabled: Confirm that the URL for all moodle JS loaded through yui_combo.php have -min.js on the end of the filename Restrict the Network tab to JavaScript Log out and navigate to the Login page Confirm that moodle-core-tooltip loaded successfully in your browser Confirm that a minified version was loaded if debugging was not enabled Confirm that a non-minified version was loaded if debugging was enabled Confirm that clicking on the [?] icon brings up the help popup correctly

      There is currently a bug in shifter which has meant that the recursive option doesn't quite work as it should. I have a patch in to fix it and I'm hoping it gets addressed soon.

      As a result though, moodle-core-tooltip was integrated with a different build (Sam modified my commit to change whitespace and the recursive build he ran modified moodle/../)

      In the mean time:

      npm install shifter@0.2.15 -g

      And here's a rebuild of moodle-core-tooltip with correct whitespace etc.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Adrian Greeve Adrian Greeve
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.