Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/davosmith/moodle.git
Pull Main Branch:
~~MDL-38426~~_dnd_plain_text
Pull Main Diff URL:
https://github.com/davosmith/moodle/compare/moodle:master...MDL-38426_dnd_plain_text
Testing Instructions:
Hide

Turn on dnd upload of text (in experimental settings)

Drag some plain text onto a course (Gedit works under Linux, maybe Notepad under Windows?)

Create a label

Check that the line breaks are retained

Drag some HTML text (out of another window of the same browser)

Create another label

Check that the HTML formatting is retained

As always with drag and drop - Firefox, Chrome, Safari, IE10
Show
Turn on dnd upload of text (in experimental settings) Drag some plain text onto a course (Gedit works under Linux, maybe Notepad under Windows?) Create a label Check that the line breaks are retained Drag some HTML text (out of another window of the same browser) Create another label Check that the HTML formatting is retained As always with drag and drop - Firefox, Chrome, Safari, IE10

Dropping plain text with line breaks isn't handled correctly by mod/label: the line breaks disappear. Davo suggests that the fix is:

"The correct fix is going to be similar to the code in mod/page/lib.php, page_dndupload_handle:

if ($uploadinfo->type == 'text/html') {

    $data->contentformat = FORMAT_HTML; $data->content = clean_param($uploadinfo->content, PARAM_CLEANHTML);

else {

    $data->contentformat = FORMAT_PLAIN; $data->content = clean_param($uploadinfo->content, PARAM_TEXT);

Participants:: Aparup Banerjee, Damyon Wiese, Davo Smith, Eloy Lafuente (stronk7), Frédéric Massart, Michael de Raadt, Patryk Szuta