Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38285 Migrate moodle- YUI modules to use shifter
  3. MDL-38404

Migrate moodle-editor_tinymce-collapse to Shifter

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.5
    • 2.5
    • JavaScript
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • Hide

      Generic Notes

      These testing instructions should be carried out twice to confirm that the correct versions of JS are used work as expected.

      Tip: Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'.

      Note: You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading.
      You can turn off comboloading to make it easier to check the relevant script by setting

      $CFG->yuicomboloading = false;

      , but you should check that functionality works with combo loading enabled.

      To test the minified code:

      Required settings:

      // Ensure you aren't overriding $CFG->jsrev
      $CFG->debug = 0;
      

      Notes

      Check that the minified version of this module is loaded.
      It will have -min.js in the filename but please ensure content is also be minified

      and to test the non-minified code:

      Required settings:

      $CFG->jsrev = -1;
      $CFG->debug = (E_ALL | E_STRICT);
      

      Notes

      Check that the non-minified version of this module is loaded.
      It will have -debug.js in the filename and the file content should not be minified.

      Module-specific test instructions

      • Open the question bank
      • Add a new multi-choice question
      • *Confirm that the 'Show editing tools' buttons are visible on the 'Choice {1,2,3}

        ' TinyMCE editors*

      • Confirm that a minified version of the JS was loaded if debug_developer is not set
      • Confirm that a raw (non-minified) version of the JS was loaded if debug_developer is set
      • Run through shifter to confirm no diff
      Show
      Generic Notes These testing instructions should be carried out twice to confirm that the correct versions of JS are used work as expected. Tip : Open your browser's developer toolkit, open the 'Network' activity tab, and restrict to 'Scripts'. Note : You may find that the script you're looking for is included with a number of other scripts - this is because of our combo loading. You can turn off comboloading to make it easier to check the relevant script by setting $CFG->yuicomboloading = false; , but you should check that functionality works with combo loading enabled. To test the minified code: Required settings: // Ensure you aren't overriding $CFG->jsrev $CFG->debug = 0; Notes Check that the minified version of this module is loaded. It will have -min.js in the filename but please ensure content is also be minified and to test the non-minified code: Required settings: $CFG->jsrev = -1; $CFG->debug = (E_ALL | E_STRICT); Notes Check that the non-minified version of this module is loaded. It will have -debug.js in the filename and the file content should not be minified. Module-specific test instructions Open the question bank Add a new multi-choice question *Confirm that the 'Show editing tools' buttons are visible on the 'Choice {1,2,3} ' TinyMCE editors* Confirm that a minified version of the JS was loaded if debug_developer is not set Confirm that a raw (non-minified) version of the JS was loaded if debug_developer is set Run through shifter to confirm no diff

      Migrate moodle-editor_tinymce modules to Shifter

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.