Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/srynot4sale/moodle.git
Pull Main Branch:
~~MDL-38011~~
Pull Main Diff URL:
https://github.com/srynot4sale/moodle/commit/ece1f162c3c0f7e0d69d7a3515ce967ae920430a
Testing Instructions:
Hide

Enable completion in advanced features
Create course with completion enabled
Add Completion Status block to course
Enrol a user in the course

Places to check roles are displayed correctly:

In course Completion Settings, under "Manual completion by"

In the course completion report (column headings)

Course Completion status block (when logged in as participant)

Course participant's details.php page (access by clicking link in status block as participant)
Show
Enable completion in advanced features Create course with completion enabled Add Completion Status block to course Enrol a user in the course Places to check roles are displayed correctly: In course Completion Settings, under "Manual completion by" In the course completion report (column headings) Course Completion status block (when logged in as participant) Course participant's details.php page (access by clicking link in status block as participant)

Support for localised role names seems to cause a regression in "Manual completion by" Course completion criteria

Step to reproduce:

To verify it depends from standard role names:

access site role definition
add a custom role name for at least one of the role that can manual approve course completion
save role definition
return to the course completion tracking page
the custom role name now appears in the "Manual completion by" criteria box

is a regression caused by

MDL-8249 Localised standard role names and descriptions

is duplicated by

MDL-39124 Names of roles are not displayed in completion tracking

Participants:: Aaron Barnes, Andrea Bicciolo, Andrew Davis, Dan Poltawski, Jason Fowler, Michael de Raadt