Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35672 META JavaScript performance issues
  3. MDL-37162

Use CSS to make mod show/hide icons not look "clickable" in hidden sections

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.3.5, 2.4.2
    • 2.2.6, 2.3.3, 2.4
    • JavaScript
    • MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • MDL-37162_master
    • Hide
      • Add an activity or resource to a section
      • Hide the section
      • Move your mouse over the hide/show icon for the resource, and confirm that it remains as the arrow rather than going to the hand icon
      • Move your mouse over the hide/show icon in a non-hidden section, and confirm that it does change to the hand icon
      Show
      Add an activity or resource to a section Hide the section Move your mouse over the hide/show icon for the resource, and confirm that it remains as the arrow rather than going to the hand icon Move your mouse over the hide/show icon in a non-hidden section, and confirm that it does change to the hand icon

      Currently, the resource toolbox initialiser (specifically, _setup_for_resource) wastes time by mucking about fetching show/hide icons and then fetching their section ancestor in order to check whether it's hidden, then pointlessly setting the show/hide icon's cursor value to "auto" if the section is hidden. This achieves nothing except wasting time - it's not even doing what it was intended to, since cursor:auto on an a tag (which the show/hide icon is) results in the hand icon anyway!

      This should be done using CSS instead (setting it to cursor:default, which actually achieves the stated goal ("Disable" show/hide icons (change cursor to not look clickable) if section is hidden).

            paul.n Paul Nicholls (Inactive)
            paul.n Paul Nicholls (Inactive)
            Andrew Lyons Andrew Lyons
            Dan Poltawski Dan Poltawski
            David Monllaó David Monllaó
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.