Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36916

Tidy up code following MDL-36638

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.4.1
    • 2.4
    • Questions, Themes
    • MOODLE_24_STABLE
    • MOODLE_24_STABLE
    • Hide

      1. Preview a question. Once you have submitted it, make sure the ticks and crosses show up correctly.

      2. Go tot he quiz reports for a quiz with attempts. Make sure the ticks and crosses show up correctly.

      Show
      1. Preview a question. Once you have submitted it, make sure the ticks and crosses show up correctly. 2. Go tot he quiz reports for a quiz with attempts. Make sure the ticks and crosses show up correctly.

      Following MDL-36638 we have code like

      if ($state == question_state::$gradedright)

      { + $icon = 'grade_correct'; }

      else if ($state == question_state::$gradedpartial)

      { + $icon = 'grade_partiallycorrect'; }

      else

      { + $icon = 'grade_incorrect'; }

      this can be simplifed to the equivalent

      $icon = 'grade_' . $state->get_feedback_class();

            timhunt Tim Hunt
            timhunt Tim Hunt
            Sam Hemelryk Sam Hemelryk
            Jason Fowler Jason Fowler
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.