Loading...

XML

Word

Printable

Type: Sub-task
Resolution: Fixed
Priority: Major
Fix Version/s: 2.3.4
Affects Version/s: 2.2.6
Component/s: JavaScript
Labels:
- patch
- triaged

Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://git.luns.net.uk/moodle.git
Pull Main Branch:
~~MDL-36752~~-master
Pull Main Diff URL:
https://git.luns.net.uk/moodle.git/commitdiff/MDL-36752-master
Testing Instructions:
Hide

I'd advise having your browsers inspector up for these tests

For master:

Open a course

Turn editing on

Turn off the activity chooser

Click the help icon next to the 'Add a resource...' dropdown

Confirm:

that the Network activity tab in your browser inspector showed a page fetch to help.php

that the correct help text is displayed

that the correct help title is displayed

Click the close button to close the tooltip

Confirm that the popup closed

Re-open the same help

Click elsewhere on the page not a link

Confirm that the popup closed

Re-open the same help

Click on another help icon

Confirm:

that the Network activity tab in your browser inspector showed a new page fetch to help.php

that the correct help text is displayed

that the correct help title is displayed

Disable JavaScript in your browser

Refresh the page

Click on the help icon again

Confirm that the help opens correctly (not a JS popup)*
Show
I'd advise having your browsers inspector up for these tests For master: Open a course Turn editing on Turn off the activity chooser Click the help icon next to the 'Add a resource...' dropdown Confirm: that the Network activity tab in your browser inspector showed a page fetch to help.php that the correct help text is displayed that the correct help title is displayed Click the close button to close the tooltip Confirm that the popup closed Re-open the same help Click elsewhere on the page not a link Confirm that the popup closed Re-open the same help Click on another help icon Confirm: that the Network activity tab in your browser inspector showed a new page fetch to help.php that the correct help text is displayed that the correct help title is displayed Disable JavaScript in your browser Refresh the page Click on the help icon again Confirm that the help opens correctly (not a JS popup)*

Although ~~MDL-35819~~ will completely rewrite tooltip help in Moodle, it cannot be backported and is highly unlikely to hit Moodle 2.4

This change will improve the (client-side) efficiency of the help tooltip in Moodle. It works in a similar way to the change in ~~MDL-35819~~ in that we move to an event delegation model rather than individual listeners for each clickable help icon.

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Frédéric Massart

Integrator:: Dan Poltawski

Tester:: Rajesh Taneja

Participants:: Andrew Lyons, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Rajesh Taneja, Sam Hemelryk

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 22/Nov/12 2:55 AM

Updated:: 01/Dec/12 10:14 AM

Resolved:: 01/Dec/12 10:14 AM

Details

Description

Attachments

Activity

People

Dates

Clockify