Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36626 Meta: Ical Bug fixes and improvments
  3. MDL-36526

Calendar does not accept URLs using the webcal:// protocol

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 2.4
    • 2.4
    • Calendar
    • MOODLE_24_STABLE
    • MOODLE_24_STABLE
    • MDL-36526-master
    • Hide
      1. Log in to Moodle as a student
      2. Go to Navigation > Site pages > Calendar.
      3. Click the button 'Manage subscriptions'.
      4. Try importing a calendar with the URL webcal://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics , no errors should be generated
      5. Try importing a calendar with the URL webcal://www.mozilla.org/proj{}ects/calendar/caldata/AustraliaHolidays.ics , "invalid url" errors should be generated
      6. Try importing a calendar with the URL http://www.mozi{}lla.org/projects/calendar/caldata/AustraliaHolidays.ics , "invalid url" errors should be generated
      7. Try importing a calendar with the URL http://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics , no errors should be generated
      8. Make sure all urls (the ones with no error) are stored as "http" not "Webcal"
      9. make sure the events are created in the calendar as expected.
      Show
      Log in to Moodle as a student Go to Navigation > Site pages > Calendar. Click the button 'Manage subscriptions'. Try importing a calendar with the URL webcal://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics , no errors should be generated Try importing a calendar with the URL webcal://www.mozilla.org/proj{}ects/calendar/caldata/AustraliaHolidays.ics , "invalid url" errors should be generated Try importing a calendar with the URL http://www.mozi {}lla.org/projects/calendar/caldata/AustraliaHolidays.ics , "invalid url" errors should be generated Try importing a calendar with the URL http://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics , no errors should be generated Make sure all urls (the ones with no error) are stored as "http" not "Webcal" make sure the events are created in the calendar as expected.

      If you try to import an external calendar with the following URL...

      webcal://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics

      The form validation regards this as an invalid URL and prompts the user for another.

      Replication steps:

      1. Log in to Moodle as a student
      2. Go to Navigation > Site pages > Calendar.
      3. Click the button 'Manage subscriptions'.
      4. Try importing a calendar with the URL webcal://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics

      Expected result: The file should be used as the basis of a calendar

      Actual result: Validation fails and user is asked to enter another URL

      Note that the calendar import does accept the same URL with the http protocol.

      http://www.mozilla.org/projects/calendar/caldata/AustraliaHolidays.ics

      The problem is that the field for the calendar URL has the type PARAM_URL, which accepts only http, https, mailto and ftp.

      The best solution would be to create some custom validation for this field that checks, if the text does not qualify using PARAM_URL, that it begins with webcal:// and the rest is a valid URL (perhaps substitute webcal for http and test).

            ankit_frenz Ankit Agarwal
            salvetore Michael de Raadt
            Mark Nelson Mark Nelson
            Dan Poltawski Dan Poltawski
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.