Loading...

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Main Branch:
~~MDL-36472~~-master
Pull Main Diff URL:
https://github.com/FMCorz/moodle/compare/moodle:master...MDL-36472-master
Testing Instructions:
Hide

Test pre-requisites

Change the setting of maxbytes to something relatively smaller

Change userquota to something a bit higher than maxbytes

Test steps

Login as a student

Go to your private files

Make sure there is a valid/correct/accurate error message when:

Uploading a larger file than maxbytes

Uploading a file which will cause userquota to be exceeded (basically upload one file, and then another one)

Drag and drop a larger file than maxbytes

Drag and drop multiple files which altogether will exceed userquota
Show
Test pre-requisites Change the setting of maxbytes to something relatively smaller Change userquota to something a bit higher than maxbytes Test steps Login as a student Go to your private files Make sure there is a valid/correct/accurate error message when: Uploading a larger file than maxbytes Uploading a file which will cause userquota to be exceeded (basically upload one file, and then another one) Drag and drop a larger file than maxbytes Drag and drop multiple files which altogether will exceed userquota

Following ~~MDL-33766~~, Mark identified the following issues:

The error messages do not have full-stops at the end of them like the other pop-up messages in the filemanager.
When I add a file via drag 'n' drop that will exceed the maximum size for new files I am given "Uploaded file NameOfFile4.txt exceeded the maximum size limit set by the form" which is fine, however when I do the same thing via the add link I am given "The uploaded file exceeds the upload_max_filesize directive in php.ini." Why the difference in messages?
When I add a file via drag 'n' drop that is less than the maximum size for new files but will exceed the overall limit I am given "Uploaded file NameOfFile3.txt exceeded the maximum size limit set by the form", this error message is wrong as it gives the impression that the file you are uploading exceeds the maximum size for a single file, when it is actually the overall limit that is being exceeded.
When I add a file via the add link that is less than the maximum size for new files but will exceed the overall limit I am given the message 'Not enough available space to store this file' (notice it is different than when I drag n drop). I find this error message misleading. It may freak out some people who believe their server has no space left and will panic thinking their Moodle is about to crash. Why not something like, 'Adding this file will exceed the overall disk space allowed per upload'?

Testing discovered

MDL-33766 My private files does not properly handle userquota & maxbytes and empty itself

Participants:: Adrian Greeve, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Helen Foster, Mark Nelson