Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36303

Event links in calendar block have HTML special entities

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 2.4
    • 2.4
    • Calendar
    • MOODLE_24_STABLE
    • MOODLE_24_STABLE
    • wip-mdl-36303
    • Hide
      1. Add two events to calendar
      2. On calendar block, make sure both events are visible.
      3. Click on event and make sure you are redirected to proper event and link should not contain 

        &

      Show
      Add two events to calendar On calendar block, make sure both events are visible. Click on event and make sure you are redirected to proper event and link should not contain &

      While adding Aria attributes we used html_writer which converts & to & for event links.

      calendar/lib.php - Line 359 should be reverted back from 

      $cell = html_writer::link((string)$dayhref, $day, array('aria-controls' => $popupid.'_panel', 'id' => $popupid));

      to

      $cell = '<a href="'.(string)$dayhref.'" '.$popupid.' aria-controls="'.$popupid.'_panel" id="'.$popupid.'">'.$day.'</a>';

      Steps to reproduce:

      1. Add two events to calendar
      2. On the calendar block, make sure both events are visible.
      3. Click on event and make sure you are redirected to proper event and link should not contain &amp;

            rajeshtaneja Rajesh Taneja
            rajeshtaneja Rajesh Taneja
            Frédéric Massart Frédéric Massart
            Dan Poltawski Dan Poltawski
            Jason Fowler Jason Fowler
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.