Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36118

LDAP sync_users performs redundant actions

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • 2.3.2
    • Authentication
    • None
    • MOODLE_23_STABLE

      When deciding whether to execute a block of code that deletes users, sync_users() uses incorrect comparison operator (trying to strictly compare a string with a numeral constant). This leads to redundant actions and performance deterioration.

      How to fix:
      in file auth/ldap/auth.php
      replace
      if ($this->config->removeuser !== AUTH_REMOVEUSER_KEEP) {
      with
      if ($this->config->removeuser != AUTH_REMOVEUSER_KEEP) {

            Unassigned Unassigned
            badblock Kirill Astashov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.