Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36027

PATCH In attribute, use & rather than & in scorm/localib.php for HTML compliance

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Minor Minor
    • None
    • 2.3.2
    • SCORM
    • MOODLE_23_STABLE

      This fixes some invalid HTML.
      On approximately line #1457 of of mod/scorm/locallib.php are the lines:

      $link = 'a='.$scorm->id.'&scoid='.$sco->id.'&currentorg='.$currentorg.$modestr.'&attempt='.$attempt;
      $result->toc .= '<a title="'.$link.'">'.$statusicon.'&nbsp;'.format_string($sco->title).'&nbsp;'.$score.'</a>';

      Because ampersand introduces an entity (like &gt, ampersand must be escaped in HTML. It should itself represented as
      an entity as it is two lines prior to the problem line. The attached patch does so as follows:

      $link = 'a='.$scorm->id.'&amp;scoid='.$sco->id.'&amp;currentorg='.$currentorg.$modestr.'&amp;attempt='.$attempt;

            danmarsden Dan Marsden
            raymor Ray Morris
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.