Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35672 META JavaScript performance issues
  3. MDL-36022

Remove shim from chooserdialogue

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.3.4
    • 2.3.2
    • JavaScript
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • MDL-36022-master
    • Hide
      • [-] Open a Course in editing mode
      • [-] Open the Activity Chooser
      • [ ] Confirm that everything works as expected - there should be no elements showing through.
      Show
      [-] Open a Course in editing mode [-] Open the Activity Chooser [ ] Confirm that everything works as expected - there should be no elements showing through.

      When I put the chooserdialogue together, I added a shim to try and work around an issue with YouTube. Turns out the issue was with the way that the YouTube video was integrated, but I forgot to remove the shim.

      I wonder whether this is the shim generating the _createShim() functions we've been seeing in the function trees recently so, since it's not required, I propose we remove it.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Dan Poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            Petr Skoda Petr Skoda
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.