Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/grabs/moodle.git
Pull Main Branch:
~~MDL-35158~~-master
Pull Main Diff URL:
https://github.com/grabs/moodle/compare/master...MDL-35158-master
Testing Instructions:
1. add a glossary activity (can be empty)
2. add a Random Glossary block and configure it - just need to point it at the glossary you added and save
3. delete the original Glossary
4. Refresh the course page

Notice: Undefined index: 72 in S:\htdocs\moodle\blocks\glossary_random\block_glossary_random.php on line 132

We're getting the above error on a course with the glossary and glossary random module installed.

Reproduction steps:

switch on debugging
add a glossary activity (can be empty)
add a Random Glossary block and configure it - just need to point it at the glossary you added and save
delete the original Glossary
Refresh the course page

Discovered while testing

MDL-36737 Strict Standards for glossary deletion

duplicates

MDL-35599 Logic in block_glossary_random->get_content() is broken

is duplicated by

MDL-35444 Random Glossary block breaks if you delete its associated Glossary

MDL-36786 PHP catchable fatal error - Random Glossary Entry block in course with no Glossary

Participants:: Allan Lee Mesina, Dan Attwood, Dan Poltawski, David Morrow, Filip Benčo, Jason Fowler, Michael de Raadt, omer, Rossiani Wijaya, Rui Az., Stephen Bloomer