-
Improvement
-
Resolution: Fixed
-
Minor
-
2.3.2
-
MOODLE_23_STABLE
-
MOODLE_24_STABLE
-
MDL-35117-master -
The backup helper which removes the excess backups could be improved. As we've seen in MDL-33812 and MDL-35116 relating on file names can lead to unexpected results. Relating on the last modification date provided by the file system can be a problem as well, some file system inaccurately update this value.
We should think of a way of improving things by reading the XML file in the backups which is the most accurate data we can get. It includes course IDs, timestamps, etc...
Here is a pastie of very quick way of retrieving information from a backup file, it only serves as an example. http://pastie.org/4608454
This implementation should be checked for performance issues, as extracting a file from thousands in a backup zip could take a while.
- blocks
-
MDL-35116 Remove old style backups from file system
-
- Closed
-
- has a non-specific relationship to
-
MDL-33812 backup_auto_keep not being honoured
-
- Closed
-
-
MDL-35075 Create PHP Unit tests for backups
-
- Closed
-
-
MDL-36116 Create PHP Unit tests for backup
-
- Closed
-
-
MDL-36117 Improving performance when using scandir() during removal of excess backups
-
- Closed
-
- has been marked as being related by
-
MDL-35116 Remove old style backups from file system
-
- Closed
-