Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 2.3.2
Affects Version/s: 2.3, 2.4
Component/s: Database SQL/XMLDB
Labels:
- triaged

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Main Branch:
w33_~~MDL-34782~~_m24_mysqlunsigned
Pull Main Diff URL:
http://github.com/skodak/moodle/compare/master...w33_MDL-34782_m24_mysqlunsigned
Testing Instructions:

Hide

1/ install 22 on mysql
2/ inject some oversized unsigned value to some table
3/ upgrade to 23
4/ expected error complaining about invalid ranges
5/ fix the value manually
6/ finish upgrade without problems

Show
1/ install 22 on mysql 2/ inject some oversized unsigned value to some table 3/ upgrade to 23 4/ expected error complaining about invalid ranges 5/ fix the value manually 6/ finish upgrade without problems

the problem is that moodle XMLDB editor specifies integer sizes in digits - that is size 3 means max 999. Unfortunately some developers ignore the allowed ranges completely which results in data loss during upgrade code in ~~MDL-27982~~

Solution is to detect the invalid values over the unsigned max and stop immediately during upgrade.

has been marked as being related by

MDL-27982 UNSIGNED 'support' in XMLDB is a big problem

Closed

Assignee:: Petr Skoda

Reporter:: Petr Skoda

Integrator:: Eloy Lafuente (stronk7)

Tester:: Ankit Agarwal

Participants:: Ankit Agarwal, Eloy Lafuente (stronk7), Mary Cooch, Mike Churchward, Petr Skoda

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 09/Aug/12 1:35 AM

Updated:: 27/Nov/13 2:24 PM

Resolved:: 17/Aug/12 3:25 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify