Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33893 new file api bugs and regressions META
  3. MDL-33894

stored_file constructor does not validate $file_record properties

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Inactive
    • Icon: Minor Minor
    • None
    • 2.3
    • Files API
    • None
    • MOODLE_23_STABLE

      Originally in 2.2 we expected record from files table, it usually comes through $fs->get_file_instance(), the problem is that the new code expects extra joined columns from other tables.

      1/ developers must be told how to add the extra columns
      2/ when the extra columns are missing we need to fetch them from DB

      I believe this is a critical issue that should be addressed before beta, please note I already complained about this before it was integrated.

      For example is_external_file() returns bogus information when incomplete $stored_file used in constructor...

            Unassigned Unassigned
            skodak Petr Skoda
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.