Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/samhemelryk/moodle.git
Pull Main Branch:
wip-~~MDL-33825~~-m23
Pull Main Diff URL:
https://github.com/samhemelryk/moodle/compare/master...wip-MDL-33825-m23
Testing Instructions:
Hide

Run phpunit tests on lib/tests/csslib_test.php

Log in as an admin

Enable css optimiser (experimental settings) and purge your caches.

Browse to a course and turn on editing

Click on the add activity link and check that the header for the dialogue has a gradient.
Show
Run phpunit tests on lib/tests/csslib_test.php Log in as an admin Enable css optimiser (experimental settings) and purge your caches. Browse to a course and turn on editing Click on the add activity link and check that the header for the dialogue has a gradient.

The following illustration shows problem clearer than I could describe it:

.userenrolment {

    background: #CCCCCC!important;

    background: -webkit-gradient(linear, left top, left bottom, from(#FFFFFF), to(#CCCCCC))!important;

    background: -moz-linear-gradient(top,  #FFFFFF,  #CCCCCC)!important;

// Gets optimised to:

.userenrolment {

  background:#CCC !important;

  background:-webkit-gradient(linear, left top, left bottom, from(#FFFFFF), to(#CCCCCC));

  background:-moz-linear-gradient(top, #FFFFFF, #CCCCCC);

has a non-specific relationship to

MDL-33584 Remove !important from modchooser CSS

Participants:: Aparup Banerjee, Dan Poltawski, Eloy Lafuente (stronk7), Mary Evans, Rossiani Wijaya, Sam Hemelryk