Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33799

/backup/restorefile.php should check the return value of $form->save_file()

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Inactive
    • Icon: Major Major
    • None
    • 2.3
    • Backup, Files API
    • MOODLE_23_STABLE
    • Easy

      While diagnosing a problem with MDL-27156 I noticed that we're not checking the return value of save_file(). That means that if there's a problem with the backup file we don't give an error until we go to read that file out of the user's draft files area much later in the process.

      If we fail to pull in the file from the repository we should stop immediately.

            Unassigned Unassigned
            andyjdavis Andrew Davis
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.