Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33592

Navigation callback for local plugins should support local_ prefix.

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.3
    • 2.3
    • Navigation
    • MOODLE_23_STABLE
    • MOODLE_23_STABLE
    • wip-MDL-33592-m23
    • Hide

      Access is required to site files for this test so you'll need a local repo.

      1. Checkout Marina's moodlecheck local plugin as a submodule to your site. git submodule add git://github.com/marinaglancy/moodle-local_moodlecheck.git local/moodlecheck
      2. Download the attached lib.php file and put it into local/moodlecheck
      3. Browse to your site and log in as an admin
      4. Check you get a Moodle code check branch in the navigation.
      5. Open local/moodlecheck/lib.php and change local_moodlecheck_extends_navigation to moodlecheck_extends_navigation.
      6. Refresh the page and check you still see the Moodle code check branch.
      Show
      Access is required to site files for this test so you'll need a local repo. Checkout Marina's moodlecheck local plugin as a submodule to your site. git submodule add git://github.com/marinaglancy/moodle-local_moodlecheck.git local/moodlecheck Download the attached lib.php file and put it into local/moodlecheck Browse to your site and log in as an admin Check you get a Moodle code check branch in the navigation. Open local/moodlecheck/lib.php and change local_moodlecheck_extends_navigation to moodlecheck_extends_navigation. Refresh the page and check you still see the Moodle code check branch.

      It would be nice to get this into Moodle 2.3, this issue is simply about adding support for the local_ prefix to the global navigation callback so that in future versions we can look to deprecate the current (conflict prone) callback.

      To outline the problem.
      Present callbacks:

      function nicehack_extends_navigation(global_navigation $nav);
      		 
      function local_nicehack_extends_settings_navigation(settings_navigation $nav, context $context);

      Desired callbacks:

      function local_nicehack_extends_navigation(global_navigation $nav);
      		 
      function local_nicehack_extends_settings_navigation(settings_navigation $nav, context $context);

        1. lib.php
          0.4 kB

            samhemelryk Sam Hemelryk
            samhemelryk Sam Hemelryk
            Dan Poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.