Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Main Branch:
~~MDL-33359~~
Pull Main Diff URL:
https://github.com/danpoltawski/moodle/compare/MDL-33359
Testing Instructions:
Hide

Run cron via CLI and web

VERIFY: Messages still get printed (starting cron... etc etc)

Run phpunit tests. You can use ~~MDL-33326~~ as the test case, or you could add the test_cron() function in the issue description to lib/filestorage/tests/file_storage_test.php
Show
Run cron via CLI and web VERIFY: Messages still get printed (starting cron... etc etc) Run phpunit tests. You can use MDL-33326 as the test case, or you could add the test_cron() function in the issue description to lib/filestorage/tests/file_storage_test.php

If mtrace outputs using normal output, then we can use the various phpunit output buffering functions to check the output of mtrace.

Also, right now, by using STDOUT during phpunit tests its very difficult to prevent the output.

The test I was starting to write:

    public function test_cron() {

        $this->resetAfterTest(true);

        $fs = get_file_storage();

        // We expect a string for two reasons, 1) because we expect to see this string,

        // 2) because using this prevents the output.

        $this->expectOutputRegex('/Cleaning up/');

        $fs->cron();

blocks

MDL-33326 Improve filestorage test coverage