Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33101

simplepie should not decode percent-encoded characters

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 2.2.2
    • RSS
    • MOODLE_22_STABLE

      for RSS feeds that link to a proxy (for authentication, or logging, ...), e.g.:

      https://www.myproxy.com/auth.phtml?url=http%3A%2F%2Fsearch.articlehost.com%2Flogin.aspx%3Fdirect%3Dtrue%26db%3Daph%26AN%3D73446%26site%3Dehost

      which the proxy will redirect to the article:
      http://search.articlehost.com/login.aspx?direct=true&db=aph&AN=73446&site=ehost

      The article URL is a query param, so it's correctly percent-encoded. However, in /lib/simplepie/simplepie.class.php, line 11402 has a section that decode the percent-encoded characters blindly, causing the proxy not being able to parse the URL.

      This bug is not in simplepie 1.2.1, only in 1.3-dev. It's ironic that the function named replace_invalid_with_pct_encoding(), yet it also did the reverse.

            poltawski Dan Poltawski
            sillyxone Huy Hoang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.