Loading...

XML

Word

Printable

Database:

Any
Affected Branches:
MOODLE_22_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/phalacee/moodle.git
Pull Main Branch:
wip-~~MDL-32946~~-master
Pull Main Diff URL:
https://github.com/phalacee/moodle/compare/master...wip-MDL-32946-master
Difficulty:
Easy
Testing Instructions:
Hide

Turn editing on for blocks

Create a HTML block with quotes and double quotes in the title

Hover over the Dock icon on the block, ensure the block's name is mentioned in the tool tip

Turn editing on for blocks

Hover over the Dock icon on the HTML block, ensure the block's name is mentioned in the tool tip
Show
Turn editing on for blocks Create a HTML block with quotes and double quotes in the title Hover over the Dock icon on the block, ensure the block's name is mentioned in the tool tip Turn editing on for blocks Hover over the Dock icon on the HTML block, ensure the block's name is mentioned in the tool tip

Funcion edit_controls on blocklib.php prints control images that have the same alternative text to each block.

Example:

$controls[] = array('url' => $actionurl . '&bui_moveid=' . $block->instance->id,

                     'icon' => 't/move', 'caption' => get_string('move'));

caption "get_string('move')" is the same to each block and is not accessible to be used.

The solution is to add contextual information to each control this way screen readers can differentiate each control:

    get_string('moveblock','',$block->title)

caused a regression

MDL-39949 Block without header causes JS error on page

will be (partly) resolved by

MDL-35832 Undock this item title not clear

Participants:: Andrew Davis, CiBoT, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Jason Fowler, Matteo Scaramuccia, Michael de Raadt, Pau Ferrer